Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opaque is ignored when used with a variant #194

Closed
benkonz opened this issue Jun 25, 2019 · 0 comments · Fixed by #199
Closed

Opaque is ignored when used with a variant #194

benkonz opened this issue Jun 25, 2019 · 0 comments · Fixed by #199

Comments

@benkonz
Copy link

benkonz commented Jun 25, 2019

Compiling this code:

type t =
  | T of {
     tbl : (string, string) Hashtbl.t [@opaque]
    }
[@@deriving show]

fails with this message:

dune exec ./main.exe
File "_none_", line 1:
Error: Unbound value Hashtbl.pp

It looks like the [@opaque] rewriter is getting ignored. The same thing happens with the [@printer ...] rewriter
gasche added a commit to gasche/ppx_deriving that referenced this issue Jul 6, 2019
@gasche
Fix handling of attributes of record fields in inline records
49dc839 
fixes ocaml-ppx#194

This bug is likely to also affect out-of-tree plugins, which should
probably be notified -- attribute propagation is currently not
centralized and has to be done by each plugin.
gasche added a commit to gasche/ppx_deriving that referenced this issue Jul 6, 2019
@gasche
Fix handling of attributes of record fields in inline records
7bf7583 
fixes ocaml-ppx#194

This bug is likely to also affect out-of-tree plugins, which should
probably be notified -- attribute propagation is currently not
centralized and has to be done by each plugin.
@gasche gasche mentioned this issue Jul 6, 2019
Merged
@cemerick cemerick mentioned this issue Dec 12, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of attributes of record fields in inline records gasche/ppx_deriving
1 participant
@benkonz