Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCaml 4.03 compatibility #3

Merged
merged 2 commits into from
May 3, 2016
Merged

Conversation

Khady
Copy link
Contributor

@Khady Khady commented May 3, 2016

I am not sure about the fix. I followed the suggestion of the compiler. But the test is passing.

@whitequark
Copy link
Collaborator

This breaks it on 4.02. Please add cppo like in this commit: ocaml-ppx/ppx_deriving_yojson@9417696

The files you need are opam, pkg/build.ml, myocamlbuild.ml, and this hack: ocaml-ppx/ppx_deriving_yojson@9417696#diff-7fa1cddad622d88b43f3838f86e70552R3.

@whitequark
Copy link
Collaborator

And I would also appreciate if you ported this commit over as well: ocaml-ppx/ppx_deriving_yojson@3922531

@Khady
Copy link
Contributor Author

Khady commented May 3, 2016

Thanks for the quick review. I will have a look at your links.

@Khady
Copy link
Contributor Author

Khady commented May 3, 2016

PR updated. Here is the log of a travis build: https://travis-ci.org/Khady/ppx_getenv/builds/127526467

@whitequark whitequark merged commit d81d5e3 into ocaml-ppx:master May 3, 2016
@whitequark
Copy link
Collaborator

Thanks!

@gasche
Copy link

gasche commented Aug 12, 2016

Would it be possible to do a ppx_getenv release with this fix? opam-builder currently reports that no ppx_getenv version works under 4.03 and 4.04 -- there may also be 4.04-specific issue but the automated builder fails on this incompatibility.

@whitequark
Copy link
Collaborator

@gasche Wish granted ocaml/opam-repository#7197

@gasche
Copy link

gasche commented Aug 13, 2016

Thanks! I may update the metadata of previous versions to mark availability as < 4.03, and I will let you know here if the automated builder gives further 4.04-specific issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants