Travis and appveyor #27
Conversation
ghost
requested a review
from 
|
Ok, this seems to be working. Some of the tests are failing under older version of OCaml though |
There was a problem hiding this comment.
The problem with the earlier versions of OCaml is that Warnings.report
(that is used to implement expect tests) does not exist.
As for instance OCaml 4.04 does not provide the hooks to implement
expect tests, I do not see how we can run the tests (unless we have a
different code path, but that seems overkill).
Would it make sense to run the tests only on the versions that can compile
expect tests, and only check that we can build on previous versions?
metaquot/ppxlib_metaquot.ml
Outdated
| @@ -39,6 +39,30 @@ module Make(M : sig | |||
| match t.ptyp_desc with | |||
| | Ptyp_extension ({ txt = "t"; _}, _ as ext)-> M.cast ext | |||
| | _ -> super#core_type t | |||
|
|
|||
There was a problem hiding this comment.
This change should probably not be part of this PR.
There was a problem hiding this comment.
(sorry, I meant the support for the new quotations - commit a836f08)
| @@ -0,0 +1,13 @@ | |||
| language: c | |||
There was a problem hiding this comment.
I suddenly feel sad. (but OCaml is not listed here)
There was a problem hiding this comment.
issue about it here: ocaml/ocaml-ci-scripts#53 ; there is a path for becoming a "community-supported language", which requires at least 3 community contributors interested in maintaining the support. We have 2 so far!
Yes, let me check if we can do that |
|
The last commit seems to do the trick |
|
Excellent! |
This PR sets up travis and appveyor using autoci (thanks @yomimono!).