fix: correctly validate argument to top-module (#6796)

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
ocaml · Dec 28, 2022 · aaa7880 · aaa7880
1 parent 904834d
commit aaa7880
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGES.md b/CHANGES.md
@@ -82,6 +82,9 @@ Unreleased
 - Allow `--sandbox` to affect `ocamldep` invocations. Previously, they were
   wrongly marked as incompatible (#6749, @rgrinberg)
 
+- Validate the command line arguments for `$ dune ocaml top-module`. This
+  command requires one positional argument (#6796, fixes #6793, @rgrinberg)
+
 3.6.1 (2022-11-24)
 ------------------
 

diff --git a/bin/top.ml b/bin/top.ml
@@ -205,7 +205,7 @@ module Module = struct
   let term =
     let+ common = Common.term
     and+ module_path =
-      Arg.(value & pos 0 string "" & Arg.info [] ~docv:"MODULE")
+      Arg.(required & pos 0 (some string) None & Arg.info [] ~docv:"MODULE")
     and+ ctx_name =
       Common.context_arg ~doc:{|Select context where to build/run utop.|}
     in