Cherry-pick fixes to toolchains branch #10476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ocaml#10213 Signed-off-by: Marek Kubica <marek@tarides.com>
In 3ea5444 the order of env updates performed by packages was reversed. This brought the behaviour of dune closer to opam but introduced a regression which prevents ocamlfind from building with dune package management. Here's an issue for tracking investigating why this change caused the regression: ocaml#10473 Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
|
Merging this without review to simplify subsequent changes, as it should be uncontraversial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two commits fixing some issues with package management that are yet to be merged into main, but which are necessary for package management to be usable in practice.