pkg: don't use "compiler" flag to identify compiler #10521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gridbugs
force-pushed
the
use-conflict-class-to-identify-compiler-packages
branch
from
8931609
to
f3ba561
Compare
gridbugs
force-pushed
the
use-conflict-class-to-identify-compiler-packages
branch
from
f3ba561
to
5d18a2b
Compare
Opam's "compiler" flag is used too broadly to accurately identify packages containing ocaml compilers. For example this flag is set for compiler options packages such as ocaml-option-flambda which configure the ocaml-variants package, effectively preventing the use of compiler options packages, as ocaml-variants also has the "compiler" flag set, and dune only permits a single compiler package in a solution. This change fixes this problem by using the presence of the "ocaml-core-compiler" conflict class to identify compiler packages. Signed-off-by: Stephen Sherratt <stephen@sherra.tt>
gridbugs
force-pushed
the
use-conflict-class-to-identify-compiler-packages
branch
from
5d18a2b
to
7171143
Compare
|
Ok I've fixed the test |
I suppose we could also lift this limitation. This fix should work as well though |
rgrinberg
approved these changes
May 14, 2024
I'm curious, how would that work? My fear is that if you mix and match compilers in your build, you get artifacts that aren't compatible with each other. |
|
The conflict class already prevents invalid build plans, so that could never happen regardless. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opam's "compiler" flag is used too broadly to accurately identify packages containing ocaml compilers. For example this flag is set for compiler options packages such as ocaml-option-flambda which configure the ocaml-variants package, effectively preventing the use of compiler options packages, as ocaml-variants also has the "compiler" flag set, and dune only permits a single compiler package in a solution.
This change fixes this problem by using the presence of the "ocaml-core-compiler" conflict class to identify compiler packages.