Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix #4097 #4106

Merged
merged 3 commits into from
Jan 13, 2021
Merged

Attempt to fix #4097 #4106

merged 3 commits into from
Jan 13, 2021

Conversation

rgrinberg
Copy link
Member

This tries to implement @snowleopard's idea of saving the exceptions in a set

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
@rgrinberg rgrinberg requested review from aalekseyev, snowleopard and a user January 13, 2021 03:53
@rgrinberg rgrinberg changed the title Attempt to fix #4015 Attempt to fix #4097 Jan 13, 2021
@rgrinberg rgrinberg linked an issue Jan 13, 2021 that may be closed by this pull request
Copy link
Collaborator

@aalekseyev aalekseyev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

src/memo/memo.ml Outdated Show resolved Hide resolved
Copy link
Collaborator

@snowleopard snowleopard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too, but see a couple of comments about comments.

Deduplicate exceptions raised by memoized functions using fiber

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix exponential blow up in Memo
3 participants