Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always use a bytecode boot.exe #463

Merged
1 commit merged into from
Jan 30, 2018
Merged

Always use a bytecode boot.exe #463

1 commit merged into from
Jan 30, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jan 30, 2018

@ghost ghost force-pushed the use-bytecode-boot-exe branch from 870eac0 to c57b049 Compare January 30, 2018 14:36
@ghost ghost requested a review from dra27 January 30, 2018 14:37
Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gosh, if it's quicker everywhere then this really is a no-brainer!

Makes one wonder if it's worth doing the entire thing in the toploop?

@ghost ghost merged commit 963bb6c into master Jan 30, 2018
@ghost
Copy link
Author

ghost commented Jan 30, 2018

Makes one wonder if it's worth doing the entire thing in the toploop?

Then there is the problem of dynamically loading unix.cma, which is not portable. It's also not very convenient for working on jbuilder itself.

@dra27
Copy link
Member

dra27 commented Jan 30, 2018

That's true about the dynamic loading. I guess it was briefly tempting to be able to have ocaml bootstrap.ml do everything (although there's no reason why the release version couldn't run boot.exe having built it too, I suppose)

For the other, I didn't think anyone else used boot.exe for developing too 😉

@ghost ghost deleted the use-bytecode-boot-exe branch February 7, 2018 14:47
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dune in master build on ppc64 (Fedora Rawhide, OCaml 4.06)
1 participant