test: remove pkg-config output for reproducibility #6543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last line changes depending on the pkg-config version. In 1.8.0 it says "Package 'fooBar', required by 'virtual:world', not found", breaking the test. Closes ocaml#6512 Signed-off-by: Etienne Millon <me@emillon.org>
rgrinberg
reviewed
Nov 22, 2022
| @@ -14,7 +14,7 @@ | |||
| > (functor Type_description)))) | |||
| > EOF | |||
|
|
|||
| $ dune build | |||
| $ bash -c 'set -o pipefail; dune build 2>&1 | head -n 20' | |||
There was a problem hiding this comment.
why do we need to run this inside bash?
There was a problem hiding this comment.
Just running dune build 2>&1 | head -n 20 always succeeds, so we lose the [1] part (we're not testing the exit code of the command anymore). set -o pipefail handles that correctly by propagating the exit code in an eager way, but requires bash. Maybe it's possible to do that in a more portable way like output=$(dune build 2>&1); r=$?; echo $output; return $r but we already depend on bash so it sounds better.
There was a problem hiding this comment.
We do depend on bash but that's a bit unfortunate
rgrinberg
approved these changes
Nov 23, 2022
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 24, 2022
* main: (58 commits) test: formatting of alternative dune files (ocaml#6567) refactor: remove Modules.is_empty (ocaml#6564) refactor: module kinds (ocaml#6562) refactor(coq): resolve lack of coqc properly Cache file contents in action builder by name. (ocaml#6555) fix: re-enable dune on older macos sdk's (ocaml#6515) fix: do not hide lib interface module (ocaml#6549) test: remove pkg-config output for reproducibility (ocaml#6543) melange: add test for ocaml flags (ocaml#6548) fix: improve virtual library error messages test: virtual library and impl locations test: alias module regression (ocaml#6544) refactor(merlin): dump config sub command (ocaml#6547) refactor: simplify merlin (ocaml#6508) chore(nix): use nix-overlays for the slim devShell (ocaml#6546) fix: module compilation rule env (ocaml#6527) chore: update nix (ocaml#6536) fix: merlin rules with pp's (ocaml#6474) Call [Dune_util.Log.init] as soon as possible (ocaml#6542) refactor: speed up stdlib build (ocaml#6524) ...
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 24, 2022
* main: test: formatting of alternative dune files (ocaml#6567) refactor: remove Modules.is_empty (ocaml#6564) refactor: module kinds (ocaml#6562) refactor(coq): resolve lack of coqc properly Cache file contents in action builder by name. (ocaml#6555) fix: re-enable dune on older macos sdk's (ocaml#6515) fix: do not hide lib interface module (ocaml#6549) test: remove pkg-config output for reproducibility (ocaml#6543) melange: add test for ocaml flags (ocaml#6548) fix: improve virtual library error messages test: virtual library and impl locations test: alias module regression (ocaml#6544) refactor(merlin): dump config sub command (ocaml#6547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last line changes depending on the pkg-config version. In 1.8.0 it says "Package 'fooBar', required by 'virtual:world', not found", breaking the test.
Closes #6512