fix: do not hide lib interface module #6549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: f6931bc9-6cd8-4172-a865-fce524052fb7
rgrinberg
force-pushed
the
ps/rr/fix__do_not_hide_lib_interface_module
branch
from
0a160f4
to
5b60193
Compare
emillon
approved these changes
Nov 24, 2022
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: f6931bc9-6cd8-4172-a865-fce524052fb7 Co-authored-by: Etienne Millon <me@emillon.org>
emillon
added a commit
to emillon/dune
that referenced
this pull request
Nov 24, 2022
Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: f6931bc9-6cd8-4172-a865-fce524052fb7 Co-authored-by: Etienne Millon <me@emillon.org>
emillon
added a commit
that referenced
this pull request
Nov 24, 2022
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Nov 24, 2022
…ne-site, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.6.1) CHANGES: - Fix status line enabled when ANSI colors are forced. (ocaml/dune#6503, @MisterDA) - Fix build with MSVC compiler (ocaml/dune#6517, @nojb) - Do not shadow library interface modules (ocaml/dune#6549, fixes ocaml/dune#6545, @rgrinberg)
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 24, 2022
* main: (58 commits) test: formatting of alternative dune files (ocaml#6567) refactor: remove Modules.is_empty (ocaml#6564) refactor: module kinds (ocaml#6562) refactor(coq): resolve lack of coqc properly Cache file contents in action builder by name. (ocaml#6555) fix: re-enable dune on older macos sdk's (ocaml#6515) fix: do not hide lib interface module (ocaml#6549) test: remove pkg-config output for reproducibility (ocaml#6543) melange: add test for ocaml flags (ocaml#6548) fix: improve virtual library error messages test: virtual library and impl locations test: alias module regression (ocaml#6544) refactor(merlin): dump config sub command (ocaml#6547) refactor: simplify merlin (ocaml#6508) chore(nix): use nix-overlays for the slim devShell (ocaml#6546) fix: module compilation rule env (ocaml#6527) chore: update nix (ocaml#6536) fix: merlin rules with pp's (ocaml#6474) Call [Dune_util.Log.init] as soon as possible (ocaml#6542) refactor: speed up stdlib build (ocaml#6524) ...
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Nov 24, 2022
* main: test: formatting of alternative dune files (ocaml#6567) refactor: remove Modules.is_empty (ocaml#6564) refactor: module kinds (ocaml#6562) refactor(coq): resolve lack of coqc properly Cache file contents in action builder by name. (ocaml#6555) fix: re-enable dune on older macos sdk's (ocaml#6515) fix: do not hide lib interface module (ocaml#6549) test: remove pkg-config output for reproducibility (ocaml#6543) melange: add test for ocaml flags (ocaml#6548) fix: improve virtual library error messages test: virtual library and impl locations test: alias module regression (ocaml#6544) refactor(merlin): dump config sub command (ocaml#6547)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there's no lib interface module present, the alias module is designated as the lib interface module. In such cases, we shouldn't shadow itself in it.