refactor(scheduler): remove duplicate types #6785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snowleopard
reviewed
Dec 28, 2022
snowleopard
reviewed
Dec 28, 2022
snowleopard
reviewed
Dec 28, 2022
snowleopard
reviewed
Dec 28, 2022
snowleopard
approved these changes
Dec 28, 2022
rgrinberg
force-pushed
the
ps/rr/refactor_scheduler___remove_duplicate_types
branch
2 times, most recently
from
81ff906
to
b5a7a1e
Compare
I think I fixed all the naming issues now. |
[Shutdown.Reason.t] and [Shutdown_reason.t] are the same modulo constructor names. Signed-off-by: Rudi Grinberg <me@rgrinberg.com> ps-id: d75c7609-cd02-4fe2-9c30-d08cd71ea60f
rgrinberg
force-pushed
the
ps/rr/refactor_scheduler___remove_duplicate_types
branch
from
b5a7a1e
to
a12b97c
Compare
rgrinberg
deleted the
ps/rr/refactor_scheduler___remove_duplicate_types
branch
jchavarri
added a commit
to jchavarri/dune
that referenced
this pull request
Dec 29, 2022
* main: (148 commits) refactor(rpc): remove mutable callback (ocaml#6786) refactor(stdune): make [Id.t] immediate (ocaml#6795) refactor(melange): share mode handling (ocaml#6799) refactor(scheduler): remove duplicate types (ocaml#6785) refactor: move cram stanza definition (ocaml#6800) fix: correctly validate argument to top-module (ocaml#6796) refactor: move generate_sites_module to own module (ocaml#6798) fix(melange): check rules (ocaml#6789) refactor(rpc): make [Call.to_dyn] public (ocaml#6797) refactor(rpc): invalid session errors (ocaml#6787) refactor(melange): remove js globs (ocaml#6782) doc: fix version indication for "dune ocaml top-module" (ocaml#6792) refactor: print shutdown exception (ocaml#6784) refactor(rpc): add [Call.to_dyn] (ocaml#6790) fix: do not impose no_sandboxing on ocamldep (ocaml#6749) refactor(melange): move stanza definition (ocaml#6775) fix: handle missing CLICOLOR_FORCE correctly (ocaml#6781) Revert --display tui (ocaml#6780) fix: render pending messages refactor(coq): inline coqc_rule ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Shutdown.Reason.t] and [Shutdown_reason.t] are the same modulo
constructor names.
Signed-off-by: Rudi Grinberg me@rgrinberg.com
ps-id: d75c7609-cd02-4fe2-9c30-d08cd71ea60f