Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(melange): check rules #6789

Merged
merged 1 commit into from
Dec 28, 2022
Merged

fix(melange): check rules #6789

merged 1 commit into from
Dec 28, 2022

Conversation

rgrinberg
Copy link
Member

@rgrinberg rgrinberg commented Dec 27, 2022

We need to add the correct set of .cmi files to the check alias depending on which mode we're working with.

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

ps-id: 060d1bce-cf5b-4ffc-a47f-dd6eefb2699d
@rgrinberg rgrinberg force-pushed the ps/rr/fix_melange___check_rules branch from c8fc467 to 1a5ddb1 Compare December 28, 2022 18:45
@rgrinberg rgrinberg merged commit da010e0 into main Dec 28, 2022
@rgrinberg rgrinberg deleted the ps/rr/fix_melange___check_rules branch December 28, 2022 19:41
jchavarri added a commit to jchavarri/dune that referenced this pull request Dec 29, 2022
* main: (148 commits)
  refactor(rpc): remove mutable callback (ocaml#6786)
  refactor(stdune): make [Id.t] immediate (ocaml#6795)
  refactor(melange): share mode handling (ocaml#6799)
  refactor(scheduler): remove duplicate types (ocaml#6785)
  refactor: move cram stanza definition (ocaml#6800)
  fix: correctly validate argument to top-module (ocaml#6796)
  refactor: move generate_sites_module to own module (ocaml#6798)
  fix(melange): check rules (ocaml#6789)
  refactor(rpc): make [Call.to_dyn] public (ocaml#6797)
  refactor(rpc): invalid session errors (ocaml#6787)
  refactor(melange): remove js globs (ocaml#6782)
  doc: fix version indication for "dune ocaml top-module" (ocaml#6792)
  refactor: print shutdown exception (ocaml#6784)
  refactor(rpc): add [Call.to_dyn] (ocaml#6790)
  fix: do not impose no_sandboxing on ocamldep (ocaml#6749)
  refactor(melange): move stanza definition (ocaml#6775)
  fix: handle missing CLICOLOR_FORCE correctly (ocaml#6781)
  Revert --display tui (ocaml#6780)
  fix: render pending messages
  refactor(coq): inline coqc_rule
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants