feat(melange): add melange.runtime_deps field in library
#7234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmonteiro
force-pushed
the
anmonteiro/melange-library-runtime-deps
branch
3 times, most recently
from
a0a2d59
to
5898b56
Compare
rgrinberg
reviewed
Mar 8, 2023
rgrinberg
reviewed
Mar 8, 2023
test/blackbox-tests/test-cases/melange/library-with-runtime-deps.t
Outdated
Show resolved
Hide resolved
rgrinberg
reviewed
Mar 8, 2023
test/blackbox-tests/test-cases/melange/public-library-with-runtime-deps.t
Outdated
Show resolved
Hide resolved
rgrinberg
reviewed
Mar 8, 2023
jchavarri
approved these changes
Mar 9, 2023
test/blackbox-tests/test-cases/melange/installed-library-with-runtime-deps.t
Outdated
Show resolved
Hide resolved
anmonteiro
force-pushed
the
anmonteiro/melange-library-runtime-deps
branch
from
aedb68a
to
2e73c70
Compare
rgrinberg
reviewed
Mar 13, 2023
| let loc = | ||
| match Lib_info.melange_runtime_deps lib_info with | ||
| | Local (loc, _) -> loc | ||
| | External _ -> Loc.none |
There was a problem hiding this comment.
Shouldn't this be assert false as well? If the runtime deps are external, the library must have been installed. Therefore, all of the paths in it cannot be external deps.
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
Signed-off-by: Javier Chávarri <javier.chavarri@gmail.com>
Signed-off-by: Antonio Nuno Monteiro <anmonteiro@gmail.com>
anmonteiro
force-pushed
the
anmonteiro/melange-library-runtime-deps
branch
from
7f9eada
to
647378e
Compare
This was referenced Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.