Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split describe into cmdliner subcommands #7919

Merged
merged 38 commits into from
Jun 12, 2023
Merged

split describe into cmdliner subcommands #7919

merged 38 commits into from
Jun 12, 2023

Commits on Jun 11, 2023

  1. refactor: move bin/describe.ml to bin/describe/ 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    511af11 View commit details
    Browse the repository at this point in the history

  2. refactor: remove indentation in describe 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a0b6193 View commit details
    Browse the repository at this point in the history

  3. refactor: What.describe takes () 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b1e1112 View commit details
    Browse the repository at this point in the history

  4. test: move dune describe tests to describe/ 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5089adf View commit details
    Browse the repository at this point in the history

  5. refactor: split dune describe into subcommands 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e21f268 View commit details
    Browse the repository at this point in the history

  6. refactor(describe): factor out What from dune describe pp 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ef3ad8e View commit details
    Browse the repository at this point in the history

  7. refactor(describe): factor out What from dune describe opam-files 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    ddd7430 View commit details
    Browse the repository at this point in the history

  8. refactor(describe): factor out What from dune describe external-lib-deps 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    5495b8c View commit details
    Browse the repository at this point in the history

  9. refactor(describe): remove some from What.describe 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6b4c83d View commit details
    Browse the repository at this point in the history

  10. refactor(describe): inline What.describe 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    830800a View commit details
    Browse the repository at this point in the history

  11. refactor(describe): remove What.t 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    cfab4b6 View commit details
    Browse the repository at this point in the history

  12. refactor(describe): factor out describe_common library 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8b615e9 View commit details
    Browse the repository at this point in the history

  13. describe: remove mention of excluding other commands in options doc 

    These options are only available for dune describe workspace

Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    e55ff19 View commit details
    Browse the repository at this point in the history

  14. refactor(describe): put describe pp in own file 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    4425add View commit details
    Browse the repository at this point in the history

  15. refactor(describe): move dune describe opam-files into own file 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b36b0df View commit details
    Browse the repository at this point in the history

  16. refactor(describe): move describe external_lib_deps to own file 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    d80c667 View commit details
    Browse the repository at this point in the history

  17. refactor(describe): move describe workspace into own file 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    529b5e5 View commit details
    Browse the repository at this point in the history

  18. doc: fix help documentation for dune describe 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1852fc3 View commit details
    Browse the repository at this point in the history

  19. refactor(describe): move describe opam-files code out of describe_common 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8d2fd15 View commit details
    Browse the repository at this point in the history

  20. refactor(describe): tighten up Describe_common.Format API 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b105109 View commit details
    Browse the repository at this point in the history

  21. refactor(describe): untangle describe pp from describe_common 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    a2b6c3a View commit details
    Browse the repository at this point in the history

  22. refactor(describe): untangle describe external-lib-deps from d_common 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    8bcf807 View commit details
    Browse the repository at this point in the history

  23. refactor(describe): move test sanitation to describe_workspace 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    01abafd View commit details
    Browse the repository at this point in the history

  24. refactor(describe): move sanitation variable to workspace 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    081752e View commit details
    Browse the repository at this point in the history

  25. refactor(describe): move workspace crawling into describe_workspace 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    066b218 View commit details
    Browse the repository at this point in the history

  26. refactor(describe): misc refactoring of describe_workspace 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    347b06f View commit details
    Browse the repository at this point in the history

  27. refator(describe): move comment about command to correct place 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    141245a View commit details
    Browse the repository at this point in the history

  28. refactor(describe_external_lib_deps): small refactorings 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    f9d414f View commit details
    Browse the repository at this point in the history

  29. refactor(describe_opam_files): remove indentation 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    6837c45 View commit details
    Browse the repository at this point in the history

  30. describe: add comments to describe_common 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    b17957d View commit details
    Browse the repository at this point in the history

  31. refactor(describe): remove describe_common lib 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    1400e36 View commit details
    Browse the repository at this point in the history

  32. describe: add comments to describe_format 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    4c65cd4 View commit details
    Browse the repository at this point in the history

  33. describe: add --lang back into describe_opam_files for backcompat 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    0b051f0 View commit details
    Browse the repository at this point in the history

  34. describe: add --lang back into describe_pp for backcompat 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    44672bb View commit details
    Browse the repository at this point in the history

  35. describe: add --lang back into external_lib_deps for backcompat 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    43ce926 View commit details
    Browse the repository at this point in the history

  36. describe: move dummy --lang argument into own module 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    4d5a2b4 View commit details
    Browse the repository at this point in the history

  37. doc(describe): add changelog for command split 

    Signed-off-by: Ali Caglayan <alizter@gmail.com>
    @Alizter
    Alizter committed Jun 11, 2023
    Configuration menu
    Copy the full SHA
    96a54ff View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. _ 

    Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
    @rgrinberg
    rgrinberg committed Jun 12, 2023
    Configuration menu
    Copy the full SHA
    9f9c8eb View commit details
    Browse the repository at this point in the history