Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split describe into cmdliner subcommands #7919

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
511af11
refactor: move bin/describe.ml to bin/describe/
Alizter Jun 7, 2023
a0b6193
refactor: remove indentation in describe
Alizter Jun 7, 2023
b1e1112
refactor: What.describe takes ()
Alizter Jun 7, 2023
5089adf
test: move dune describe tests to describe/
Alizter Jun 7, 2023
e21f268
refactor: split dune describe into subcommands
Alizter Jun 8, 2023
ef3ad8e
refactor(describe): factor out What from dune describe pp
Alizter Jun 8, 2023
ddd7430
refactor(describe): factor out What from dune describe opam-files
Alizter Jun 8, 2023
5495b8c
refactor(describe): factor out What from dune describe external-lib-deps
Alizter Jun 8, 2023
6b4c83d
refactor(describe): remove some from What.describe
Alizter Jun 8, 2023
830800a
refactor(describe): inline What.describe
Alizter Jun 8, 2023
cfab4b6
refactor(describe): remove What.t
Alizter Jun 8, 2023
8b615e9
refactor(describe): factor out describe_common library
Alizter Jun 8, 2023
e55ff19
describe: remove mention of excluding other commands in options doc
Alizter Jun 8, 2023
4425add
refactor(describe): put describe pp in own file
Alizter Jun 8, 2023
b36b0df
refactor(describe): move dune describe opam-files into own file
Alizter Jun 8, 2023
d80c667
refactor(describe): move describe external_lib_deps to own file
Alizter Jun 8, 2023
529b5e5
refactor(describe): move describe workspace into own file
Alizter Jun 8, 2023
1852fc3
doc: fix help documentation for dune describe
Alizter Jun 8, 2023
8d2fd15
refactor(describe): move describe opam-files code out of describe_common
Alizter Jun 9, 2023
b105109
refactor(describe): tighten up Describe_common.Format API
Alizter Jun 9, 2023
a2b6c3a
refactor(describe): untangle describe pp from describe_common
Alizter Jun 9, 2023
8bcf807
refactor(describe): untangle describe external-lib-deps from d_common
Alizter Jun 9, 2023
01abafd
refactor(describe): move test sanitation to describe_workspace
Alizter Jun 9, 2023
081752e
refactor(describe): move sanitation variable to workspace
Alizter Jun 9, 2023
066b218
refactor(describe): move workspace crawling into describe_workspace
Alizter Jun 9, 2023
347b06f
refactor(describe): misc refactoring of describe_workspace
Alizter Jun 9, 2023
141245a
refator(describe): move comment about command to correct place
Alizter Jun 9, 2023
f9d414f
refactor(describe_external_lib_deps): small refactorings
Alizter Jun 9, 2023
6837c45
refactor(describe_opam_files): remove indentation
Alizter Jun 9, 2023
b17957d
describe: add comments to describe_common
Alizter Jun 9, 2023
1400e36
refactor(describe): remove describe_common lib
Alizter Jun 9, 2023
4c65cd4
describe: add comments to describe_format
Alizter Jun 9, 2023
0b051f0
describe: add --lang back into describe_opam_files for backcompat
Alizter Jun 9, 2023
44672bb
describe: add --lang back into describe_pp for backcompat
Alizter Jun 9, 2023
43ce926
describe: add --lang back into external_lib_deps for backcompat
Alizter Jun 9, 2023
4d5a2b4
describe: move dummy --lang argument into own module
Alizter Jun 10, 2023
96a54ff
doc(describe): add changelog for command split
Alizter Jun 11, 2023
9f9c8eb
_
rgrinberg Jun 12, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Unreleased
- Allow `(include_subdirs qualified)` to be used when libraries define a
`(modules ...)` field (#7797, fixes #7597, @anmonteiro)

- `$ dune describe` is now a command group, so arguments to subcommands must be
passed after subcommand itself. (#7919, @Alizter)

- The `interface` and `implementation` fields of a `(dialect)` are now optional
(#7757, @gpetiot)

Expand Down
Loading
Loading