Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dune when installing via OPAM #28

Closed
wants to merge 1 commit into from
Closed

Use dune when installing via OPAM #28

wants to merge 1 commit into from

Conversation

Leonidas-from-XIV
Copy link
Contributor

This uses dune to build and install the generated artifacts when installed via OPAM using the default dune commands that the dune documentation suggests.

I am not sure this has been proposed before, I couldn't find anything in that regard.

Dune also supports a split between development mode and release mode where warnings are not fatal, hence:

Closes #19

This uses `dune` to build and install the generated artifacts when
installed via OPAM.

Dune also supports a split between development mode and release mode
where warnings are not fatal, hence

Closes #19
@dra27
Copy link
Member

dra27 commented Jun 17, 2022

Dune also supports a split between development mode and release mode where warnings are not fatal, hence:

This isn't true, because of

num/src/dune

Line 19 in 703e1f8

(flags -w +a-4-9-41-42-44-45-48 -warn-error +A -g -safe-string -strict-sequence -strict-formats))

@dra27
Copy link
Member

dra27 commented Jun 17, 2022

This PR as it stands would break the installation guarantees for num on 4.06-4.14. Wherever possible, the num library should be installed to ocaml's lib directory.

The dune files also contain some minor errors which prevents their being immediately switched to as an installation mechanism.

However, I have some commits which in addition to #29 would improve the situation and we could look at dune being a depopt for num in the same way as, say, opam-file-format.

@Leonidas-from-XIV Leonidas-from-XIV closed this by deleting the head repository May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't release with -warn-error A
2 participants