Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamlformat support #292

Closed
hannesm opened this issue Apr 24, 2019 · 2 comments
Closed

ocamlformat support #292

hannesm opened this issue Apr 24, 2019 · 2 comments

Comments

@hannesm
Copy link
Member

hannesm commented Apr 24, 2019

It would be good to integrate ocamlformat into CI scripts to adapt it into more projects, and have a CI job which checks that the submitted PRs conform to the selected style. I'd propose to require the ocamlformat version explicitly OCAMLFORMAT="0.9" (avoiding issues like the latest for OCAML_VERSION which support we phased out over time -- it's utopic to assume all ci-script users will always want the same version of ocamlformat).

I've recently seen this commit which contains necessary changes (of course they need to be adapted to the scripts here).

if others think this is a good idea, and someone more familiar with the current code base could implement it, that'd be great! :)

//cc @NathanReb @emillon @avsm @samoht (further discussion also in mirage/ocaml-cstruct#234)

@NathanReb
Copy link

I'm actually experimenting around this atm. I think a more satisfying way to deal with this would be to check formatting on a separate build.

That would allow us to get the results for this check faster since it doesn't require you to install any dependencies and to actually build or run the test for the project.

You can have a look at this PR I wrote. The ocamlformat build is separate from the other ones and uses images with pre-installed versions of ocamlformat and dune. Right now they're hosted on my dockerhub but it would be nice to have them on the ocaml one.

@hannesm
Copy link
Member Author

hannesm commented Aug 2, 2023

since I do not use ocaml-ci-scripts any longer, I'll close this.

@hannesm hannesm closed this as completed Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants