Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix abs_pos computing in String_zipper.drop_until #1278

Merged
merged 1 commit into from
May 17, 2024

Conversation

emilienlemaire
Copy link
Contributor

This PR should fix a problem that occurs when editing a text document with apply_text_document_edits, where some text could be duplicated, as shown in #1207.

@coveralls
Copy link

coveralls commented May 17, 2024

Pull Request Test Coverage Report for Build 4250

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.189%

Totals Coverage Status
Change from base Build 4249: 0.0%
Covered Lines: 5147
Relevant Lines: 24291

💛 - Coveralls

@rgrinberg rgrinberg force-pushed the fix-string-zipper branch 2 times, most recently from 88a0789 to 2fd9670 Compare May 17, 2024 17:10
@rgrinberg
Copy link
Member

rgrinberg commented May 17, 2024

Thanks for the fix. In fact, this PR is two independent fixes and I would like tests for each individual fix separately. The abs_pos fix is in fact not covered by the tests, as you can see here: #1280

EDIT: managed to add a separate test for abs_pos management

@rgrinberg rgrinberg added this to the 1.18.0 milestone May 17, 2024
@rgrinberg rgrinberg merged commit 70574f6 into ocaml:master May 17, 2024
9 checks passed
@rgrinberg
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants