Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: inlay hints #1345

Merged
merged 1 commit into from
Jul 14, 2024
Merged

refactor: inlay hints #1345

merged 1 commit into from
Jul 14, 2024

Conversation

rgrinberg
Copy link
Member

  • create and populate hints in the same thread
  • reduce scope of bindings

Signed-off-by: Rudi Grinberg me@rgrinberg.com

* create and populate hints in the same thread
* reduce scope of bindings

Signed-off-by: Rudi Grinberg <me@rgrinberg.com>

<!-- ps-id: 0f85c5aa-579f-4b70-9ed9-95bba529cd14 -->
Copy link

Pull Request Test Coverage Report for Build 4440

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 21.754%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/inlay_hints.ml 15 16 93.75%
Totals Coverage Status
Change from base Build 4439: 0.007%
Covered Lines: 5528
Relevant Lines: 25412

💛 - Coveralls

@rgrinberg rgrinberg merged commit ba546ad into master Jul 14, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant