Glob: do not skip over backslashes under Windows #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that a better fix would be to add an argument to |
|
Friendly ping |
|
Thanks! |
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
Sep 9, 2021
CHANGES: * Glob: add optional argument `?backslash_escapes` to control interpretation of backslashes (useful under Windows) (ocaml/ocaml-re#197, ocaml/ocaml-re#198) * Restore accidentally deleted `*_seq` deprecated aliases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(The first commit is just to fix the build following #192)
Currently
Globskips over backslashes, interpreting the character following one "literally". This is wrong on Windows, where backslashes are perfectly good characters in pathnames. This commit makes the "skip over backslash" logic only apply when not on Windows.Note that there may be other fixes necessary to work well under Windows, but this is already an improvement.
This PR fixes (at least in some cases) the issue reported in ocaml-ppx/ocamlformat#1773