Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn exercise 009 into practice #2177

Closed
cuihtlauac opened this issue Mar 13, 2024 · 5 comments · Fixed by #2229
Closed

Turn exercise 009 into practice #2177

cuihtlauac opened this issue Mar 13, 2024 · 5 comments · Fixed by #2229
Labels
beginner can be done by an OCaml beginner exercise good first issue Good for newcomers help wanted outreachy Outreachy contributions and blog posts

Comments

@cuihtlauac
Copy link
Collaborator

cuihtlauac commented Mar 13, 2024

Extract the OCaml code from the markdown file corresponding to this exercise. The file is: data/exercise/009_NAME.md (where 009 is the number from the title of this issue and NAME is the rest of the file name, for instance data/exercise/001_tail.md is the file which corresponds to exercise 001). Use the code in this file to create a folder practice/009 (using this same number).

Populate the 009 folder with (almost) the same files as in folders practice/001 and practice/002 (they are examples).

Three files are different in each folder:

  1. practice/009/ex.ml: it contains the function's signature, which needs to be implemented by the learner;
  2. practice/009/work/impl.ml: it includes the template meant to be filed by the learner;
  3. practice/009/answer/impl.ml: consists of the solution from the original markdown file.

The examples included in the original markdown file must be turned into test cases in the practice/009/ex.ml file.

Folder structure to create:

practice/009/
├── answer
│   ├── impl.ml
│   └── test
│       ├── dune
│       └── run.ml
├── dune
├── dune-project
├── ex.ml
└── work
    ├── impl.ml
    └── test
        ├── dune
    
@cuihtlauac cuihtlauac added beginner can be done by an OCaml beginner exercise good first issue Good for newcomers help wanted outreachy Outreachy contributions and blog posts labels Mar 13, 2024
@Kxrishx03
Copy link
Contributor

Hii! @cuihtlauac Can I take part in it?

@cuihtlauac
Copy link
Collaborator Author

Yes @Kxrishx03, go for it

@jahielkomu
Copy link
Contributor

Hi @Kxrishx03, I hope you are well.
Are you working on this?

@Kxrishx03
Copy link
Contributor

@jahielkomu I've completed the task, waiting for PR to get approved.

@cuihtlauac cuihtlauac linked a pull request Mar 19, 2024 that will close this issue
@cuihtlauac
Copy link
Collaborator Author

@jahielkomu I've completed the task, waiting for PR to get approved.

You still have request changes

cuihtlauac pushed a commit that referenced this issue Mar 26, 2024
* "Pratice-009-done"

* "Done"

* Update impl.ml

* Update run.ml

* Update impl.ml

* Update ex.ml

* Update dune

* Do not touch irrelevant file

* "Update -lines added"

* "Update -Extra lines deleted"

* "Update -Extra lines deleted"

* Update ex.ml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginner can be done by an OCaml beginner exercise good first issue Good for newcomers help wanted outreachy Outreachy contributions and blog posts
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants