Turn exercise 009 into practice #2177 #2229
Conversation
Kxrishx03
changed the title
|
Please include a newline at the end of all the files. |
|
Please review now . @divyankachaudhari |
|
@Kxrishx03 I'm just an outreachy applicant as well 😅 I was just trying to help you with the experience I got with my PRs. |
practice/009/work/test/dune
Outdated
| @@ -0,0 +1,2 @@ | |||
| (include_subdirs no) | |||
| (test (name run) (libraries ounit2 ex)) | |||
There was a problem hiding this comment.
Please add newline at end of the file
practice/009/dune-project
Outdated
| @@ -0,0 +1 @@ | |||
| (lang dune 3.7) | |||
There was a problem hiding this comment.
Please add newline at end of the file
practice/009/answer/impl.ml
Outdated
| if a = b then aux (a :: current) acc t | ||
| else aux [] ((a :: current) :: acc) t in | ||
| List.rev (aux [] [] list);; | ||
|
|
There was a problem hiding this comment.
Please add newline at end of the file
There was a problem hiding this comment.
Actually, here it's delete empty line and finish with newline
practice/001/answer/test/run.ml
Outdated
There was a problem hiding this comment.
You've still modified the 001 folder.
There was a problem hiding this comment.
How do i remove that @divyankachaudhari ? I don't have much experience with github actually.
There was a problem hiding this comment.
Revert the change you've made. Here in practice/001/answer/test/run.ml, you've accidentally added space in a new line, so just remove that. A way to prevent such accidental changes is when you use git add only specify git add <folder you're modifying> so you don't add any accidental changes to your commit :)
There was a problem hiding this comment.
@Kxrishx03: Just do something like git checkout main -- practice/001/answer/run.ml and then git commit -a -m 'Do not touch irrelevant file'
Keep in mind that the added value of this internship is learning functional programming and ocaml, git is more a prerequisite ❤️
There was a problem hiding this comment.
@cuihtlauac Thanks for the reviews. I will make the requested changes right away!
There was a problem hiding this comment.
@cuihtlauac I've made changes as you suggested. Please review! Thank you so much!!!
|
@Kxrishx03 make sure |
practice/001/answer/test/run.ml
Outdated
There was a problem hiding this comment.
@Kxrishx03: Just do something like git checkout main -- practice/001/answer/run.ml and then git commit -a -m 'Do not touch irrelevant file'
Keep in mind that the added value of this internship is learning functional programming and ocaml, git is more a prerequisite ❤️
…3/ocaml.org into practice_009_issue_2177
practice/009/answer/impl.ml
Outdated
| if a = b then aux (a :: current) acc t | ||
| else aux [] ((a :: current) :: acc) t in | ||
| List.rev (aux [] [] list);; | ||
|
|
There was a problem hiding this comment.
Actually, here it's delete empty line and finish with newline
practice/009/dune-project
Outdated
| @@ -0,0 +1 @@ | |||
| (lang dune 3.7) | |||
practice/009/work/test/dune
Outdated
| @@ -0,0 +1,2 @@ | |||
| (include_subdirs no) | |||
| (test (name run) (libraries ounit2 ex)) | |||
|
@cuihtlauac I've removed all the extra empty line & added new line. |
|
@cuihtlauac Hi! Thanks for guiding me through the task. I would like to keep contributing. Please assign me some tasks. |
Please review & suggest if any corrections needed.