Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookbook : Web / simple HTTP client #2123

Closed
wants to merge 24 commits into from
Closed

Cookbook : Web / simple HTTP client #2123

wants to merge 24 commits into from

Conversation

F-Loyer
Copy link
Contributor

@F-Loyer F-Loyer commented Feb 29, 2024

A very simple cookbook...

tmattio and others added 20 commits March 1, 2024 17:27
@tmattio @sabine
Prototype OCaml Cookbook
be1fc0c
@sabine
add a rule to crunch the cookbook directory
faf82a2
@sabine
move position of cookbook
436bc12
@sabine
side-by-side code view like Go by Example
41a762e
@sabine
copy to clipboard, random number gen recipe
6255df9
@sabine
hierarchy: category > task > recipe
ca107df 
- URL we serve this under is docs/cookbook/[task slug]/[recipe slug]
- multiple recipes per task
- recipe page displays links to other recipes for the same task
@sabine
bring back the styles on the input that I accidentally replaced by 'h…
457d9a9 
…idden'
@sabine
move cookbook to community section, refactor active_top_nav_item to b…
98e1c25 
…e controlled by learn_layout.eml and community_layout.eml
@sabine
move to Learn area
9df1b8b
@F-Loyer @loyer78
@christinerose @sabine
Cookbook : encoding (ocaml#2097)
a4d5a22 
* Cookbook index : add encoding

* Cookbook encoding typos

* Add dune

* Update 00-camomile.md / remove tab

* Update 00-camomile.md / remove tab

* Update 00-camomile.md

* Apply suggestions from code review

Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
@F-Loyer @loyer78 @sabine
Cookbook : and Sorting list and arrays (ocaml#2098)
fbd4a2d 
* Cookbook: add Sorting

* Update 00-stdlib.md / remove tabs

* Update 00-stdlib.md / remove tabs

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
@F-Loyer @loyer78 @sabine
Cookbook textprocessing (ocaml#2104)
702c9f4 
* Cookbook: text processing

* Cookbook: text processing (remove tabs)

* Cookbook: text processing (typo)

* Cookbook: text processing (typo)

* Cookbook: text processing (typo)

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
@F-Loyer @loyer78 @sabine
Cookboot : Add a Database / ezsqlite entry (ocaml#2100)
9cc3abe 
* Cookbook : Database/ezsqlite

* Remove tabs

* Declare packages

* Indent error

* typo

* Update cookbook_categories.yml : fix folder name in cookbook_categories.yml

* Update cookbook_categories.yml - cookbook index fix

* Update 00-ezsqlite.md

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
@F-Loyer @loyer78 @sabine
Cookbook concurrency : Lwt (ocaml#2107)
8e3402c 
* Cookbook: add concurrency / Lwt

* Cookbook: add concurrency / Lwt - fix

* Cookbook: add concurrency / Lwt - fix

* Cookbook: add concurrency / Lwt - fix

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
@F-Loyer @loyer78 @sabine
Cookbook caqti ppx rapper (ocaml#2108)
afc3d1d 
* Cookbook : Caqti and ppx_rapper

* Cookbook : Caqti and ppx_rapper - fix

* Cookbook : Caqti and ppx_rapper - fix

* Cookbook : Caqti and ppx_rapper - @ notation

* add query with WITH clause

* typo WITH/WHERE

* fix

* fix

* fix

* fix

* fix

---------

Co-authored-by: Frederic LOYER <frederic.loyer@club-internet.fr>
@sabine
simplify data format of cookbook files
d7bcb48
@sabine
change data format to .ml file with YAML header, comments get display…
b6d1d6b 
…ed side-by-side with the code
@F-Loyer @loyer78 @sabine
Cookbook Ezsqlite - typo and rewriting (ocaml#2119)
060502f 
Co-authored-by: Frédéric LOYER <frederic.loyer@club-internet.fr>
@F-Loyer @loyer78 @sabine
Cookbook Sorting - typo (ocaml#2118)
3ade56c 
Co-authored-by: Frédéric LOYER <frederic.loyer@club-internet.fr>
@sabine
add dark mode styles
cb2863c
christinerose
christinerose reviewed Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few questions & suggestions

@samoht
Copy link
Member

samoht commented Mar 4, 2024 •
edited

I'm not convinced that ocamlnet should be the framework recommended for new users. Is the goal to show all the existing frameworks? Or should we recommend one?

@F-Loyer @christinerose
Update data/cookbook/web-programming/simple-http-client/00-camlnet.ml
8e7db31 
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
@F-Loyer
Copy link
Contributor Author

F-Loyer commented Mar 4, 2024 •
edited

I'm not convinced that ocamlnet should be the framework recommended for new users. Is the goal to show all the existing frameworks? Or should we recommend one?

But the convenience module of Ocamlnet is "convenient" - see the proposed snippet : 2 lines - (but quite basic). I have a Cohttp/Lwt snippet if it is prefered...

@tmattio
Copy link
Collaborator

tmattio commented Mar 5, 2024

I think ocamlnet is unmaintained and incompatible with OCaml 5, so I would also suggest not advertising it as a viable option in the Cookbook :)

cuihtlauac
cuihtlauac requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set upstream from https://github.com/ocaml/ocaml.org/tree/cookbook-httpclient

@cuihtlauac cuihtlauac force-pushed the cookbook branch 2 times, most recently from caf127e to 7f8c3b8 Compare April 16, 2024 13:40
@cuihtlauac cuihtlauac deleted the branch ocaml:cookbook April 23, 2024 10:06
@cuihtlauac cuihtlauac closed this Apr 23, 2024
@cuihtlauac cuihtlauac reopened this Apr 23, 2024
@sabine sabine deleted the branch ocaml:cookbook May 6, 2024 13:42
@sabine sabine closed this May 6, 2024
cuihtlauac pushed a commit that referenced this pull request May 6, 2024
Cookbook HTTP client\n\nRecreate PR #2123 from https://github.com/oca…
b42cfe6 
…ml/ocaml.org/tree/cookbook-httpclient
@cuihtlauac cuihtlauac mentioned this pull request May 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christinerose christinerose christinerose left review comments

@cuihtlauac cuihtlauac cuihtlauac requested changes

Assignees
No one assigned
Labels
Cookbook documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@F-Loyer @samoht @tmattio @cuihtlauac @christinerose @sabine @loyer78