-
Notifications
You must be signed in to change notification settings - Fork 326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cookbook httpclient #2402
Open
cuihtlauac
wants to merge
1
commit into
main
Choose a base branch
from
cookbook-httpclient
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cookbook httpclient #2402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
cuihtlauac
commented
May 6, 2024
- Prototype OCaml Cookbook
- add a rule to crunch the cookbook directory
- move position of cookbook
- side-by-side code view like Go by Example
- copy to clipboard, random number gen recipe
- hierarchy: category > task > recipe
- bring back the styles on the input that I accidentally replaced by 'hidden'
- move cookbook to community section, refactor active_top_nav_item to be controlled by learn_layout.eml and community_layout.eml
- move to Learn area
- Cookbook : encoding (Cookbook : encoding #2097)
- Cookbook : and Sorting list and arrays (Cookbook : and Sorting list and arrays #2098)
- Cookbook textprocessing (Cookbook textprocessing #2104)
- Cookboot : Add a Database / ezsqlite entry (Cookboot : Add a Database / ezsqlite entry #2100)
- Cookbook concurrency : Lwt (Cookbook concurrency : Lwt #2107)
- Cookbook caqti ppx rapper (Cookbook caqti ppx rapper #2108)
- simplify data format of cookbook files
- change data format to .ml file with YAML header, comments get displayed side-by-side with the code
- Cookbook Ezsqlite - typo and rewriting (Cookbook Ezsqlite - typo and rewriting #2119)
- Cookbook Sorting - typo (Cookbook Sorting - typo #2118)
- add dark mode styles
- Cookbook : fix in Lwt (type mismatch with iter_s/iter_p functions) (Cookbook : fix in Lwt (type mismatch with iter_s/iter_p functions) #2127)
- Update 00-caqti-ppx-rapper.ml - fix sqlite -> sqlite3 (Update 00-caqti-ppx-rapper.ml - fix caqti-driver-sqlite -> caqti-driver-sqlite3 #2126)
- rearrange category hierarchy and render all recipes for a task, name rercipes based on task and first listed package
- rebase
- add some tasks
- list the task separately in the table and all the recipes below the task
- add aria-label to make clear to screen-readers where the recipe link is going
- Added description field to tasks
- Task pages
- Task description
- Remove str and stdlib recipes
- Cookbook description text
- Formatting
- minor style changes
- Formatting
- Update CONTRIBUTING.md
- Fix tasks.yml processing
- Formatting
- Add Yaml deserializing recipe
- Refactor JSON tasks
- Text and formatting
- Review
- Remove sorting recipe
- Cleanup
- Delete postponed recipes
- Update localtime recipe
- Do not display package versions
- Formatting
- Display used libraries per package
- Display version as tested and category path
- Fix contribution text
- Fixes
- Formatting
- Fix category path
- Formatting
- Refactoring
- Add hl_yaml recipe
- Fix comments
- Formatting
- Formatting
- Review edits
- Fix typo
- Import FS tasks from PR 1400
- Bring back random generation
- Bring back random generation, con't
- Read text and gziped file
- Formatting
- Fix typo
- Formatting
- Remove some recipes
- Rebase
- Make task description optional
- Random values
- Formatting
- Locate errors
- Rebased http client recipe
- Minimize task.yml
- Cookbook HTTP client\n\nRecreate PR Cookbook : Web / simple HTTP client #2123 from https://github.com/ocaml/ocaml.org/tree/cookbook-httpclient
sabine
force-pushed
the
cookbook-httpclient
branch
from
May 9, 2024 10:39
b42cfe6
to
7f5c633
Compare
cuihtlauac
force-pushed
the
cookbook-httpclient
branch
from
May 13, 2024 12:24
7f5c633
to
926eb17
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few typos & added two words to clarify.
|
||
let url = "https://www.ocaml.org" | ||
|
||
(* The `get` function fetch the ressource. The status code is analysed, and if all is ok, return the body of the answer. If not, the reason of the failure *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
(* The `get` function fetch the ressource. The status code is analysed, and if all is ok, return the body of the answer. If not, the reason of the failure *) | |
(* The `get` function fetches the resource. The status code is analysed, and if all is ok, returns the body of the answer. If not, it returns the reason of the failure *) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.