Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in 4ad_01_operators.md #2219

Merged
merged 4 commits into from Mar 25, 2024
Merged

Fix typo in 4ad_01_operators.md #2219

merged 4 commits into from Mar 25, 2024

Conversation

vog
Copy link
Contributor

@vog vog commented Mar 15, 2024

No description provided.

@vog vog requested a review from christinerose as a code owner March 15, 2024 02:00
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @vog, thanks for that!

However, the typo is not at line 98, it's a line 107. There it should be 1. instead of .2. We try to use automatically numbered lists, only using one.

Automatic numbering does not work here because sublists items at lines 96-97, 99-100, 104-106 and 108-110 aren't indented enough, using 4 space characters restores the automatic numbering in the top-level lists.

Can you do that?

@vog
Copy link
Contributor Author

vog commented Mar 22, 2024

Ok, I'll try to fix that

@vog
Copy link
Contributor Author

vog commented Mar 22, 2024

@cuihtlauac Done. Please check again if the code is now indented as intended. (pun intentional)

data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
data/tutorials/language/4ad_01_operators.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@cuihtlauac cuihtlauac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vog, this is nicer. I've also fixed the syntax for unary operators which was wrong.

@cuihtlauac cuihtlauac merged commit d89e804 into ocaml:main Mar 25, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants