Events feed #2495
Events feed #2495
Conversation
|
|
Sure thing, will update asap, AFK rn |
There was a problem hiding this comment.
Thanks @ishar19, this is nice. I've committed the trivial stuff. Two issues remain
- published_date is not set to the right value
- Date processing may have useless steps
| in | ||
| Syndic.Atom.entry ~id ~authors | ||
| ~title:(Syndic.Atom.Text (log.title ^ " " ^ start_date_str)) | ||
| ~updated:start_date |
There was a problem hiding this comment.
The event start date should not be used here. The updated date is when the event announcement is created or updated.
There was a problem hiding this comment.
Oh sure, I'm in my uni rn for an exam, will check back later
There was a problem hiding this comment.
@cuihtlauac i checked the event feed markdown files, there isn't any updated date field
should i put a conditional whether when updated is present to use that or leave it as it is, thanks!
There was a problem hiding this comment.
For 1-shot events, we need an additional field in Event.t to hold that information. When all is built, using the function decode, we must initialize it with the file's last write time on the markdown.
For recurring events, it's trickier. We have to check in the RSS spec if it is allowed to skip that field.
There was a problem hiding this comment.
I tried to research whether we can omit the field in recurring events or not but couldn't find anything substantial, will need some help here
There was a problem hiding this comment.
A possible solution could be to use the filesystem information for one-shot events and remove recurring events from the feed. Does it make sense to you?
tool/ood-gen/lib/event.ml
Outdated
| ^ ":00Z" | ||
| let id = Uri.of_string (log.slug ^ " " ^ start_date_str) in |
There was a problem hiding this comment.
@ishar19 : please fix the syntax error here
| in | ||
| Syndic.Atom.entry ~id ~authors | ||
| ~title:(Syndic.Atom.Text (log.title ^ " " ^ start_date_str)) | ||
| ~updated:start_date |
There was a problem hiding this comment.
For 1-shot events, we need an additional field in Event.t to hold that information. When all is built, using the function decode, we must initialize it with the file's last write time on the markdown.
For recurring events, it's trickier. We have to check in the RSS spec if it is allowed to skip that field.
Can you please explain "filesystem information" |
File modification information. Right now we're using |
oh alright, thanks,i will look into it |
Co-authored-by: Cuihtlauac Alvarado <cuihtlauac@users.noreply.github.com>
sabine
force-pushed
the
events_feed
branch
2 times, most recently
from
7ca142f
to
3faab0e
Compare
Resolves #2392
Creating a new PR with updated logic