Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diskuv OCaml docs when OCaml 5 is released #554

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jonahbeckford
Copy link
Contributor

This is how I think Diskuv OCaml and the rest of the Windows options should look after the platform installer + Opam 2.2 + OCaml 5 are released. This accompanies and replicates much of #539 (but it explicitly de-elevates Diskuv OCaml).

@panglesd
Copy link
Contributor

Hello Jonah!

In your #539 PR, you made some modifications of the "Up and Running" page, such as this or that and maybe more.

You did not included those modifications in this new PR. And that's a good thing, as there is already a PR in progress modifying this file! #548

Do you prefer to include your changes in your PR, once #548 is merged and you are rebased on it? Or, do you prefer that we do those modifications in #548?

@jonahbeckford
Copy link
Contributor Author

Can you include them in #548? Not for any noble reason, but because I'm on vacation for a couple weeks and waiting for me to get access to a make start capable PC will block everyone needlessly.

@panglesd
Copy link
Contributor

Sure! Thanks for your answer and enjoy your vacation.

Copy link
Collaborator

@christinerose christinerose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly grammar/capitalization suggestions. A few for syntax/clarity.

data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
data/tutorials/gs_03_ocaml_on_windows.md Outdated Show resolved Hide resolved
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
Co-authored-by: Christine Rose <christinerose@users.noreply.github.com>
@tmattio
Copy link
Collaborator

tmattio commented Sep 24, 2022

@jonahbeckford I just rebased the PR on top of main. In anticipation of the release of opam 2.2: I think this will also need an update to the Up and Running guide, which now recommends using Diskuv to setup OCaml on Windows

@cuihtlauac
Copy link
Collaborator

@jonahbeckford: Can you review this PR now that OCaml 5 has been released?

@jonahbeckford
Copy link
Contributor Author

I think this will need to be released when both OCaml 5 and opam 2.2 are ready. opam 2.2 is not here yet, so the page won't make much sense.

@dra27 Are there any updates to the docs that you'd want to see in the interim period between now (OCaml 5) and opam 2.2 release?

@dra27
Copy link
Member

dra27 commented Jan 5, 2023

Certainly not before the alpha release - the content of this PR (at a quick look) can probably go live once the alpha is tagged.

@sabine sabine added documentation stalled Blocked waiting. Will not progress w/o external progress and removed waiting on tool release labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation stalled Blocked waiting. Will not progress w/o external progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants