Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factor out reading OCAMLTOP_INCLUDE_PATH in ocaml/ocamlnat #11158

Merged
merged 1 commit into from
Apr 4, 2022

Conversation

dra27
Copy link
Member

@dra27 dra27 commented Apr 4, 2022

ocaml and ocamlnat both contain identical code for parsing OCAMLTOP_INCLUDE_PATH.

(This refactor is a precursor to another PR, but further deduplicating toplevel code stands in its own right)

Copy link
Contributor

@abbysmal abbysmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I'll go ahead and merge it.

@abbysmal abbysmal merged commit 1414cce into ocaml:trunk Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants