fix speculative usage of <sys/shm.h> in AFL runtime #1278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of relying on a blacklist (_WIN32 || __ANDROID__) of systems not providing <sys/shm.h>, figure out its presence in ./configure. This fixes the build with a minimal libc, such as ocaml-freestanding.
|
I think this should probably have a Changes entry in the "compiler build" section or whatever it's called. |
mshinwell
approved these changes
Aug 9, 2017
|
@mshinwell done -- it is reassuring that appveyor reports success :) |
|
looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of relying on a blacklist
(_WIN32 || __ANDROID__)of systems notproviding
<sys/shm.h>, figure out its presence in./configure. This fixesthe build with a minimal libc, such as ocaml-freestanding.
Further discussion in mirage/ocaml-solo5#23 (comment)
I don't think a Changes entry is necessary for this, please let me know if you disagree and I'll add one. @stedolan I hope this change is fine with you.
//cc @mato @avsm