Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of the [@@immediate] information when checking [@@unboxed] #1469

Merged
merged 1 commit into from Dec 10, 2017

Conversation

Projects
None yet
4 participants
@damiendoligez
Copy link
Member

damiendoligez commented Nov 8, 2017

When checking whether the [@@unboxed] annotation on a type is acceptable, we can make use of the information given by [@@immediate] annotations on other types.

Suggested by Stephan Muenzel.

See also MPR#7511 GPR#606 GPR#1133.

@damiendoligez damiendoligez force-pushed the damiendoligez:unboxed-immediate-type branch 2 times, most recently from 73d840e to 2306e60 Nov 8, 2017

@alainfrisch

This comment has been minimized.

Copy link
Contributor

alainfrisch commented Nov 8, 2017

(Also related to #1262.)

@alainfrisch
Copy link
Contributor

alainfrisch left a comment

LGTM

@gasche

gasche approved these changes Nov 24, 2017

Copy link
Member

gasche left a comment

Someone has to update the Changes entry before this gets merged. @alainfrisch, are you planning to merge now?

@gasche gasche force-pushed the damiendoligez:unboxed-immediate-type branch from 2306e60 to 4e9c510 Dec 10, 2017

@gasche

This comment has been minimized.

Copy link
Member

gasche commented Dec 10, 2017

I just rebased the PR and will merge in trunk if the CI passes.

@gasche gasche merged commit 7a7bf05 into ocaml:trunk Dec 10, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

trefis added a commit that referenced this pull request Dec 25, 2017

@trefis

This comment has been minimized.

Copy link
Contributor

trefis commented Dec 25, 2017

Seems like you had forgotten the Changes update before merging.
I pushed 1707e24 to fix that.

@damiendoligez damiendoligez deleted the damiendoligez:unboxed-immediate-type branch Feb 22, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.