Make use of the [@@immediate] information when checking [@@unboxed] #1469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damiendoligez
force-pushed
the
unboxed-immediate-type
branch
2 times, most recently
from
73d840e
to
2306e60
Compare
|
(Also related to #1262.) |
gasche
approved these changes
Nov 24, 2017
There was a problem hiding this comment.
Someone has to update the Changes entry before this gets merged. @alainfrisch, are you planning to merge now?
gasche
force-pushed
the
unboxed-immediate-type
branch
from
2306e60
to
4e9c510
Compare
|
I just rebased the PR and will merge in trunk if the CI passes. |
trefis
added a commit
that referenced
this pull request
Dec 25, 2017
|
Seems like you had forgotten the Changes update before merging. |
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
--------- Co-authored-by: Sabine Schmaltz <sabineschmaltz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking whether the
[@@unboxed]annotation on a type is acceptable, we can make use of the information given by[@@immediate]annotations on other types.Suggested by Stephan Muenzel.
See also MPR#7511 GPR#606 GPR#1133.