Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add locations to toplevel directives #1954

Merged
merged 1 commit into from
Aug 6, 2018
Merged

Add locations to toplevel directives #1954

merged 1 commit into from
Aug 6, 2018

Conversation

hhugo
Copy link
Contributor

@hhugo hhugo commented Aug 1, 2018

similar to #1953
This additional location will be useful to ocamlformat when deciding where to print comments.

Drup
Drup approved these changes Aug 1, 2018
View reviewed changes
Copy link
Contributor

@Drup Drup left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that I said in #1953 (comment) applies here.

gasche
gasche approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@gasche gasche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed but I trust @Drup's approval. @hhugo, could you update the Changes entry, squash your commits together, and I'll merge?

@hhugo
Copy link
Contributor Author

hhugo commented Aug 6, 2018

rebased and squashed

@gasche gasche merged commit 35218bf into ocaml:trunk Aug 6, 2018
@hhugo hhugo deleted the locs branch August 6, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasche gasche gasche approved these changes

@Drup Drup Drup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hhugo @gasche @Drup