Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add locations to toplevel directives #1954

merged 1 commit into from Aug 6, 2018


None yet
3 participants
Copy link

commented Aug 1, 2018

similar to #1953
This additional location will be useful to ocamlformat when deciding where to print comments.


Drup approved these changes Aug 1, 2018

Copy link

left a comment

Everything that I said in #1953 (comment) applies here.


gasche approved these changes Aug 6, 2018

Copy link

left a comment

I haven't reviewed but I trust @Drup's approval. @hhugo, could you update the Changes entry, squash your commits together, and I'll merge?

@hhugo hhugo force-pushed the hhugo:locs branch from 1164b87 to c4dd1e6 Aug 6, 2018


This comment has been minimized.

Copy link
Contributor Author

commented Aug 6, 2018

rebased and squashed

@gasche gasche merged commit 35218bf into ocaml:trunk Aug 6, 2018

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
continuous-integration/travis-ci/pr The Travis CI build passed

@hhugo hhugo deleted the hhugo:locs branch Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.