Avoid overflow on 32-bit architectures causing bad GC behavior #546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alainfrisch
changed the title
|
Looks like the best fix for this problem. FTR, the only drawback is that it'll make life a bit harder for people who run OCaml on systems without floating-point. [edit: in fact it doesn't, we already had doubles in this code] |
This was referenced Mar 14, 2019
EduardoRFS
pushed a commit
to esy-ocaml/ocaml
that referenced
this pull request
May 17, 2021
coverage of domain life-cycle in domain_dls and ephetest_par tests
stedolan
pushed a commit
to stedolan/ocaml
that referenced
this pull request
May 24, 2022
EmileTrotignon
pushed a commit
to EmileTrotignon/ocaml
that referenced
this pull request
Jan 12, 2024
merlin-js also has a pin-depends on jsoo-code-mirror, and it seems that we need the same in ocamlorg: https://deploy.ci.ocaml.org/job/2022-08-09/145812-ocluster-build-bdf2ff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://caml.inria.fr/mantis/view.php?id=7228
It would be worth creating a non-regression test for this one, but one should certainly include the fix in 4.03 even without the test.