New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
configure: optimistically enable native dynlink on recent 32bit darwin hosts #692
Conversation
…n hosts See camlp4/camlp4#108: native dynlink seems to work correctly on recent OSX machines (Darwin15, OSX 10.11), even on 32 bit setups. 32bit setups were broken by OSX toolchain changes on darwin{10,11} (10.6, 10.7) so all 32bit darwin versions above darwin9 were pessimistically disabled. (Apparently the user demand for 32bit darwin host support is that core_kernel assumes 32bit machines, at least when used in combination with js_of_ocaml).
5abf627
to
b9b8324
Compare
There is no need to be optimistic, I have virtual machines running under Darwin1[234]. Let me test and report here. |
I've tried on Darwin12 to Darwin15 and they all failed with this error:
|
Something weird is going on. At what point of the build does this error occur? |
In |
Gentle ping: the camlp4 users are discussing applying the patch on their opam switches, so it would be interesting to find out whether it is actually safe. |
I'm still surprised that @damiendoligez observed an error on
|
Concerning the need to avoid "common" variables in MacOS X, see https://caml.inria.fr/mantis/view.php?id=5693#c7798 |
@damiendoligez Could you try the suggested change? |
The error message is slightly different:
Then, if I comment out line 156 of
I get this error instead:
So it's not just |
@damiendoligez 's observations are consistent with the hypothesis that MacOS x86-32 does NOT support dynamic linking of non-PIC code. In itself I'm not surprised. The mystery is the claim that it works found in the camlp4 github. |
Maybe it depends on the Xcode version, although I do have the latest version (8.2.1). |
It seems that my general optimism in life does not always match reality. I would vote to close the PR, and wait for a user with an actually reproducible story to maybe restart the discussion. |
There is some information in MPR#6900 that may be relevant. |
* Set ocamlformat to 0.24.1 * Undo dune-project changes * Format code base * Update ocamlformat version globally Co-authored-by: Cuihtlauac ALVARADO <cuihtmlauac@tarides.com> Co-authored-by: Thibaut Mattio <thibaut.mattio@gmail.com>
See camlp4/camlp4#108: native dynlink seems to work correctly on recent
OSX machines (Darwin15, OSX 10.11), even on 32 bit setups. 32bit
setups were broken by OSX toolchain changes on darwin{10,11} (10.6,
10.7) so all 32bit darwin versions above darwin9 were pessimistically
disabled.
(Apparently the user demand for 32bit darwin host support is that
core_kernel assumes 32bit machines, at least when used in combination
with js_of_ocaml).