Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: optimistically enable native dynlink on recent 32bit darwin hosts #692

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions Changes
Expand Up @@ -155,6 +155,12 @@ OCaml 4.04.0:
- GPR#507: More sharing between Unix and Windows makefiles
(whitequark, review by Alain Frisch)

- GPR#692: optimistically enable native dynlink on recent 32bit darwin hosts
(natdynlink is known to not work on darwin{10,11} (OSX 10.6, 10.7),
and seems to work on darwin15 (OSX 10.11); please open an issue if
you notice that it is broken on darwin{12,13,14})
(Gabriel Scherer, report by Maciej Woś)


### Bug fixes:

Expand Down
8 changes: 7 additions & 1 deletion configure
Expand Up @@ -770,10 +770,16 @@ if test $with_sharedlibs = "yes"; then
i[3456]86-*-gnu*) natdynlink=true;;
x86_64-*-linux*) natdynlink=true;;
i[3456]86-*-darwin[89].*) natdynlink=true;;
i[3456]86-*-darwin*)
i[3456]86-*-darwin1[01].*)
# the 32bit toolchains of darwin{10,11} (OSX 10.6 and 10.7)
# are known to break native dynlink
if test $arch64 == true; then
natdynlink=true
fi;;
i[3456]86-*-darwin*)
# for darwin versions above darwin12 we optimistically enable
# native dynlink even on 32bit setups
natdynlink=true;;
x86_64-*-darwin*) natdynlink=true;;
s390x*-*-linux*) natdynlink=true;;
powerpc*-*-linux*) natdynlink=true;;
Expand Down