-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tools/check-parser-uptodate-or-warn.sh #8979
Conversation
eb6601a
to
6c8a84b
Compare
Rather than peppering the diff with |
then | ||
exit 0 | ||
fi | ||
grep -Fq '+dev' VERSION || exit 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How portable is this change to different grep
implementations? I'm worried about using anything more than the simplest grep
command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already checked - -F
and -q
are both POSIX, as is the combination of them to -Fq
!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for the others, the -F
is overkill, for this one it seems sensible in case some naughty grep
treats +
as magic without enabling EREs)
By the way, I recommend to use |
eef24f6
to
55755d8
Compare
May I ask, when this landed in the trunk, will it be a part of the future 4.09.1 release, or only for 4.10.0 one? |
There's no reason not to push it to the 4.09 branch, but there's no guarantee that there will be a 4.09.1 release. |
(I decided to wait for the INRIA CI reports before backporting into 4.09.) |
Fix tools/check-parser-uptodate-or-warn.sh (cherry picked from commit f075ab6)
This PR fixes #8965 (a build failure caused by a warning script) by:
stat
to the script