Run whole of gen_primitives.sh with LC_ALL=C #8986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ocaml#8985. Assuming the locale has been generated, running LC_COLLATE=sv_SE.UTF-8 make world failed previously since the w character is not matched in [a-z] in this locale.
|
Thanks for a prompt fix. :) |
nojb
approved these changes
Sep 26, 2019
|
Thanks! |
|
I think this can be back-ported to 4.09? @gasche |
|
Yes, sounds good to me. (Unless we are already in the process of preparing a minor release, and extra carefulness must apply, I would say that any "safe" bugfix can be backported to a release branch if you find it important. "safe" when we are confident that it has a low risk of introducing unexpected regressions.) |
|
Got it, thanks. 4.09 commit is 3ef8ce7 |
|
Thanks, @nojb! It was otherwise on my (hour behind) morning task list 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I reproduced #8985. The glibc bug report referenced there suggests that the collation rules are not correct for Swedish, but regardless that means we should switch to forcing C collation in the entire script, which this PR does.
CC @sebras