Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ppopt and ppxopt options #45

Closed
Drup opened this issue Jan 18, 2016 · 4 comments · Fixed by #265
Closed

ppopt and ppxopt options #45

Drup opened this issue Jan 18, 2016 · 4 comments · Fixed by #265

Comments

@Drup
Copy link

Drup commented Jan 18, 2016

It doesn't seem possible to add these ocamlfind options in the _tag file

@gasche
Copy link
Member

gasche commented Jan 18, 2016

Indeed; a pull request would be warmly welcome.

@whitequark
Copy link
Member

Duplicate of #190, which has more context.

@argent-smith
Copy link

argent-smith commented Dec 26, 2017

I've just encountered this issue: lwt docs say I can specify -ppxopt lwt.ppx,-no-debug but when compiling with ppxopt(lwt.ppx,-no-debug) I get "Warning: tag "ppxopt" does not expect a parameter, but is used with parameter "lwt.ppx,-no-debug".

@gasche
Copy link
Member

gasche commented Jan 2, 2018

Thanks for the (reiterated) request, I proposed an implementation in #265.

@gasche gasche mentioned this issue Sep 8, 2018
gasche added a commit to gasche/opam-repository that referenced this issue Sep 8, 2018
OCamlbuild 0.13.0 contains new features (`ppopt(..)` and `ppxopt(...)` flags,
ocamlbuild options) and bugfixes (to pack production, for 4.08+dev support).

- ocaml/ocamlbuild#45, ocaml/ocamlbuild#190: add ppopt(arg) and ppxopt(package,arg) when -use-ocamlfind
  (Gabriel Scherer, review by whitequark,
   request by Gabriel Scherer, Gabriel Radanne and Pavel Argentov)

- ocaml/ocamlbuild#268, ocaml/ocamlbuild#269: add flag support for some ocamlmklib options:
  custom, debug, failsafe, linkall, ccopt(..), cclib(..), rpath(..), ldopt(..)
  (Gabriel Scherer, report by Hannes Mehnert, review by whitequark)

* ocaml/ocamlbuild#272: add the "link" tag to "pack" actions
  Instead of a separate category, "pack" is now another form of linking
  like "program", "library", "toplevel" and "output_obj". This fixes
  the issue that package(...) tags where not passed at pack-production
  time, spotted by Jérémie Dimino. More generally, this extends
  the meaning of all "link" flags to "pack", which seems to be the correct
  behavior for all the rules we inspected.
  (Gabriel Scherer, original issue diagnosis by Jérémie Dimino)

- ocaml/ocamlbuild#278: typo fixes in the manual
  (Xinzhe Yang)

- ocaml/ocamlbuild#282: fix compilation with trunk OCaml (4.08+dev)
  (Xavier Clerc and Nandor Licker)
gasche added a commit to gasche/opam-repository that referenced this issue Sep 14, 2018
OCamlbuild 0.13.0 contains new features (`ppopt(..)` and `ppxopt(...)` flags,
ocamlbuild options) and bugfixes (to pack production, for 4.08+dev support).

- ocaml/ocamlbuild#45, ocaml/ocamlbuild#190: add ppopt(arg) and ppxopt(package,arg) when -use-ocamlfind
  (Gabriel Scherer, review by whitequark,
   request by Gabriel Scherer, Gabriel Radanne and Pavel Argentov)

- ocaml/ocamlbuild#268, ocaml/ocamlbuild#269: add flag support for some ocamlmklib options:
  custom, debug, failsafe, linkall, ccopt(..), cclib(..), rpath(..), ldopt(..)
  (Gabriel Scherer, report by Hannes Mehnert, review by whitequark)

* ocaml/ocamlbuild#272: add the "link" tag to "pack" actions
  Instead of a separate category, "pack" is now another form of linking
  like "program", "library", "toplevel" and "output_obj". This fixes
  the issue that package(...) tags where not passed at pack-production
  time, spotted by Jérémie Dimino. More generally, this extends
  the meaning of all "link" flags to "pack", which seems to be the correct
  behavior for all the rules we inspected.
  (Gabriel Scherer, original issue diagnosis by Jérémie Dimino)

- ocaml/ocamlbuild#278: typo fixes in the manual
  (Xinzhe Yang)

- ocaml/ocamlbuild#282: fix compilation with trunk OCaml (4.08+dev)
  (Xavier Clerc and Nandor Licker)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants