New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reinstate z3 package from @Drup with a stable release #10815
Conversation
✅ All lint checks passed 894b545
✅ Installability check (7787 → 7788)
|
I don't get why the datakit tests fail so fast, and I don't know how to access the error files to check why… |
Not sure what's wrong exactly… |
On MacOS X, Travis fails with:
|
Ah, yeah, the .install written by @Drup might be linux-specific :-( |
|
||
messages: [ | ||
"Before installing any package depending on Z3, please export the following variable: | ||
export LD_LIBRARY_PATH=\"$(ocamlfind printconf destdir)/stublibs:${LD_LIBRARY_PATH}\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you try to get rid of that ? I feel like this is not really acceptable if it gets into opam's main repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get rid of this, indeed. Why is it needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the time, it was needed because the package recompile Z3 entirely, Z3's build system was complicated and because I'm not very good at C(++) linking rules.
Now, I think it would be better to rely on system-provided .so/.h files, but it needs modifying Z3's build system or just plain extracting the OCaml part, and building it outside.
opam's LLVM package does the former, so I guess it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
modifying Z3's build system? :-/
this sounds super awful…
Ping. Do we have a chance to have a nice solution this time around? (I think many people would be interested in having an easy way to use Z3 using |
Sorry I haven't updated this. I don't know of a solution that would be simple enough (building manually seems a bit too scary, especially when Z3 maintainers themselves are moving to cmake). So I'm closing this until a better, cleaner solution is found… |
Trying to resurrect the package for Z3 and its OCaml bindings.
Previously:
Licensing problems should be gone, since Z3 is now under MIT. I added a package for the last release and the
dev-repo
field.