+ qfs 0.9 #13703
+ qfs 0.9 #13703
Conversation
packages/qfs/qfs.0.9/opam
Outdated
| ["ocaml" "setup.ml" "-configure" "--prefix" prefix] | ||
| ["ocaml" "setup.ml" "-build"] | ||
| ["ocaml" "setup.ml" "-configure" "--enable-tests"] {with-test} | ||
| ["ocaml" "setup.ml" "-build"] {with-test} |
There was a problem hiding this comment.
the build and configure steps are going to be done twice. I don't think this is what you wanted to do. I would suggest to place the {with-test} attribute to the argument for the configure and to omit the second build command line as it is redundant with the first one which is done unconditionally
packages/qfs/qfs.0.9/opam
Outdated
| ["ocaml" "setup.ml" "-doc"] {with-doc} | ||
| ] | ||
| install: ["ocaml" "setup.ml" "-install"] | ||
| remove: [ |
There was a problem hiding this comment.
the remove field can be omitted with opam2
|
thanks, fixed |
☀️ All lint checks passed 3b7dd90
☀️ Installability check (10843 → 10844)
|
sorry, what I meant about this comment is my latest commit |
|
It should be ok now. Thanks! |
|
I didn't know one could do that, nice! |
CI build is expected to fail due to absent libqfs