Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owl-ode, owl-ode-sundials: release 0.1.0 #14552

Merged

Conversation

mseri
Copy link
Member

@mseri mseri commented Jul 18, 2019

This pull-request concerns:
-owl-ode.0.1.0: Owl's ODE solvers
-owl-ode-sundials.0.1.0: Owl's ODE solvers, interface with SundialsML



🐫 Pull-request generated by opam-publish v2.0.0

@mseri mseri changed the title v0.1.0 owl-ode, owl-ode-sundials: release 0.1.0 Jul 18, 2019
@mseri mseri force-pushed the opam-publish-owl-ode-owl-ode-sundials.0.1.0 branch from 048188c to d6ecdac Compare July 18, 2019 20:19
@mseri mseri changed the title owl-ode, owl-ode-sundials: release 0.1.0 v0.1.0 Jul 18, 2019
@mseri mseri changed the title v0.1.0 owl-ode, owl-ode-sundials: release 0.1.0 Jul 18, 2019
@mseri
Copy link
Member Author

mseri commented Jul 18, 2019

Unfortunately in debian buster libsundials-serial-dev is no longer present and has been replaced by libsundials-dev. So the build will always fail

@mseri
Copy link
Member Author

mseri commented Jul 18, 2019

The 4.08.0 failure happens during the tests due to the usual mysterious error:

          - owl-ode → owl >= 0.6.0 → eigen >= 0.1.0 → ctypes >= 0.14.0 → lwt < 4.0.0 → ocaml < 4.08.0

The one on mac is due to a too recent version of sundials

@kit-ty-kate
Copy link
Member

Unfortunately in debian buster libsundials-serial-dev is no longer present and has been replaced by libsundials-dev. So the build will always fail

Doesn't it make more sense to change it since the old one is not supposed to be used anymore?

Signed-off-by: Marcello Seri <marcello.seri@gmail.com>
@mseri
Copy link
Member Author

mseri commented Jul 19, 2019

I've modified it, but the ocaml sundials version targets a very specific version, so I don't know if it is going to be working or not. If we see that it does not work, I'll remove the commit.

I have decided to keep the old version as it will not prevent people stuck to older systems to keep their automatic setups

@mseri
Copy link
Member Author

mseri commented Jul 19, 2019

Much better. I have added a workaround for the tests in docker in the next release, I am going to disable them for the moment.

@mseri
Copy link
Member Author

mseri commented Jul 19, 2019

There will be distributions not providing ploplot nor sundials (or the version we need). Those will unfortunately fail

@camelus
Copy link
Contributor

camelus commented Jul 19, 2019

🌤️ opam-lint warnings b7f954e
  • sundialsml.3.1.1p0-1 has some warnings:

    • warning 58: Found doc variable, predefined one is with-doc
  • These packages passed lint tests: owl-ode-sundials.0.1.0, owl-ode.0.1.0


☀️ Installability check (+3)
  • new installable packages (3): owl-ode.0.1.0 owl-ode-sundials.0.1.0 sundialsml.3.1.1p0-1

@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit df15350 into ocaml:master Jul 19, 2019
@mseri mseri deleted the opam-publish-owl-ode-owl-ode-sundials.0.1.0 branch July 16, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants