Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accessor*, higher_kinded, and ppx_accessor packages. #16562

Merged
merged 3 commits into from
Jun 11, 2020

Conversation

xclerc
Copy link
Contributor

@xclerc xclerc commented Jun 2, 2020

This pull requests fixes the following packages by adding a public_name stanza (See [1]):

  • accessor;
  • accessor_async;
  • accessor_base;
  • accessor_core;
  • higher_kinded;
  • ppx_accessor.

[1] https://discuss.ocaml.org/t/ann-v0-14-release-of-jane-street-packages/5893/9

@xclerc
Copy link
Contributor Author

xclerc commented Jun 2, 2020

(Do not merge, this pull request needs additional commits.)

@camelus
Copy link
Contributor

camelus commented Jun 2, 2020

Commit: 6adf2fc

A pull request by opam-seasoned @xclerc.

☀️ All lint checks passed 6adf2fc
  • These packages passed lint tests: accessor.v0.14.1, accessor_async.v0.14.1, accessor_base.v0.14.1, accessor_core.v0.14.1, higher_kinded.v0.14.1, ppx_accessor.v0.14.1

☀️ Installability check (+6)
  • new installable packages (6): accessor.v0.14.1 accessor_async.v0.14.1 accessor_base.v0.14.1 accessor_core.v0.14.1 higher_kinded.v0.14.1 ppx_accessor.v0.14.1

@xclerc
Copy link
Contributor Author

xclerc commented Jun 5, 2020

https://github.com/ocaml/opam-repository/pull/16562/commits/ba464086519e6fdc8d01b1d6apend557ea8b8fc06c67 is expected to fix the pending issues by:

  • adding the missing applicative_without_return library (in accessor);
  • updating the dependencies of the various packages.

@xclerc
Copy link
Contributor Author

xclerc commented Jun 5, 2020

(The Travis error is a timeout.)

@kit-ty-kate
Copy link
Member

thanks a lot! Sorry for the time this took, we had lots of issues in our CI

@kit-ty-kate kit-ty-kate merged commit 0c1b84c into ocaml:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants