New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] colibrilib, colibrics and colibri2 (0.4) #23244
Conversation
@Gbury There is a strange behavior of dolmen in 5.0. I don't know where the problem is (colibri2, dolmen, ocaml) but after raising an exception inside a pipeline of dolmen, there is a syscall read with the file descriptor
|
@bobot there is indeed a bug with dolmen and ocaml 5.0, related to finalisers. It turns out to be a bug in the implementation of the gc in |
For some more explanation: a finaliser is called too early (before the related value is unreachable), and the finaliser actually closes the |
I propose to add in this MR the conflict now in dolmen |
Since i expect the finaliser bug to be patched in an upcoming |
2cc141e
to
6639a18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flint's tests also fail on OCaml 5.0:
# File "flint/tests/dune", line 9, characters 8-15:
# 9 | (names dynamic)
# ^^^^^^^
# (cd _build/default/flint/tests && ./dynamic.exe)
# Fatal error: exception Dynlink.Error (Dynlink.Cannot_open_dll "Dynlink.Error (Dynlink.Cannot_open_dll \"Failure(\\\"/home/opam/.opam/5.0/lib/ctypes/ctypes.cmxs: cannot open shared object file: No such file or directory\\\")\")")
For ocaml 5.0 the problem was in ctypes: yallop/ocaml-ctypes#727 , |
0acd797
to
0599ebe
Compare
0599ebe
to
2058004
Compare
I think it is okay now. The last problem are 5.0 because of ctypes which is in another MR, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why my review was requested (since this PR does not modify dolmen
packages anymore), but I'm happy to approve, ^^
@kit-ty-kate could you merge this PR? |
CHANGES: * Decision: Fix delayed decisions handling * Array: experimental theory * Quantifier: Improve eager instanciation heuristic * Quantifier: Avoid creating new term * Simplex: Fix redundant run * Fix compilation in 32bit * Fix sign of sqrt
2058004
to
3fcd6f5
Compare
@kit-ty-kate Flint and the others have been removed, so the remaining packages are not failing anymore. |
The remaining failures are likely going away once the mac-compatible arb, flint and calcium are released |
Thanks |
1 similar comment
Thanks |
CHANGES: