Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] embedded_ocaml_templates (0.8) #23419

Merged

Conversation

EmileTrotignon
Copy link
Contributor

EML is a simple templating language that lets you generate text with plain OCaml

CHANGES:

Bugfixes

  • Locations of errors in the ppx are now reported correctly.

@EmileTrotignon EmileTrotignon force-pushed the release-embedded_ocaml_templates-0.8 branch from 3520033 to abe7f59 Compare February 27, 2023 15:46
@mseri
Copy link
Member

mseri commented Mar 29, 2023

Do you understand why those tests are failing?

@EmileTrotignon
Copy link
Contributor Author

Hi @mseri , thanks for taking the time to look at this.
I am not sure why they fail, but it may be related to fixes in the OCaml parser and AST.
I will have more time to investigate tomorrow, but if I fail to fix it, it should be okay to bump the required OCaml version.

@EmileTrotignon
Copy link
Contributor Author

I have checked, and this is indeed caused by changes in the OCaml parsetree : compare line 34 of 4.10.2/parsetree.mli with line 34 of 4.11.0/parsetree.mli
I will deactivate the tests before 4.11 : eml is still usable, it will just be less ergonomic.

@EmileTrotignon EmileTrotignon force-pushed the release-embedded_ocaml_templates-0.8 branch from 9ff856e to 328eaa8 Compare March 30, 2023 13:51
CHANGES:

Bugfixes
- Locations of errors in the ppx are now reported correctly.
@EmileTrotignon EmileTrotignon force-pushed the release-embedded_ocaml_templates-0.8 branch from 328eaa8 to 46178ab Compare March 30, 2023 15:06
@EmileTrotignon
Copy link
Contributor Author

A single test fails on x86_32, because of a weird warning that shows up in the cram test. In my opinion that is not a big deal, and I do not see an easy way of fixing it, but I do not know opam's policy.

@mseri
Copy link
Member

mseri commented Mar 31, 2023

That's fine, thanks a lot!

@mseri mseri merged commit c8e139b into ocaml:master Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants