Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add afl-2.57b package. #23964

Merged
merged 1 commit into from
Jun 21, 2023
Merged

Add afl-2.57b package. #23964

merged 1 commit into from
Jun 21, 2023

Conversation

tmcgilchrist
Copy link
Contributor

This is the last official release from https://github.com/google/AFL/releases.

It's not clear how I can test this locally within opam. I have applied the patch manually to the project source and that works ok. Submitting here to get testing on various platforms.

@avsm
Copy link
Member

avsm commented Jun 21, 2023

Just restarting a failed macos/arm build (SIGBUS on git reset?!), but otherwise looks fine.

synopsis:
"American Fuzzy Lop fuzzer by Michal Zalewski, repackaged for convenient use in opam"
authors: "Michal Zalewski"
depends: ["ocaml"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this, the package only depends on a c compiler, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, I merged before seeing this. I think @mseri is right...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it only depends on a c compiler.
What's the correct way to depend on that? @mseri

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is (conf-gcc | conf-clang) but I am not 100% sure. If there is ocaml, most likely there is also the c compiler, so even though it is not strictly required perhaps is a good idea to keep it as is

@avsm avsm merged commit d664515 into ocaml:master Jun 21, 2023
2 checks passed
@tmcgilchrist tmcgilchrist deleted the afl-2.57b branch July 3, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants