-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new-release] melange (4.0.0) #25885
Conversation
Can you have a look at the failures in the tests? |
|
We also would need a
|
@mseri thanks for the fixes but I’d rather disable running the tests instead. |
"@doc" {with-doc} | ||
] | ||
] | ||
available: arch != "x86_32" & arch != "arm32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anmonteiro no problem in disabling the tests but please port this fix upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a bit annoying since available
isn't supported in the dune-project file and we'll have to track a melange.opam.template
...
Are these build errors expected?
and
They keep appearing every now and then |
The first one seems like a legitimate failure. a bit annoying since it doesn't happen in our CI. The 2nd one was a missed lower bound on OCaml 5.2 |
not sure why CI is still building 32-bit versions given the |
303fd15
to
797478c
Compare
OK I think this finally looks good. Thanks for your help @mseri. The failures in CI seem to be solver timeouts. |
Thanks! |
Toolchain to produce JS from Reason/OCaml
Project page: https://github.com/melange-re/melange
This release includes a version for each of the following OCaml compiler versions: 4.14, 5.1 and the freshly released 5.2.