Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cairo package renaming, lablgl support for lablgtk2 #997

Merged
merged 2 commits into from
Aug 21, 2013

Conversation

william3
Copy link
Contributor

Hello,
two commits :

  • cairo : package rename. it is important, because opam use the directory name to install ocamlfind META package. Without change, cairo1.ocaml opam package installs "cairo" ocamlfind package in cairo sub directory, which could be fine, but "cairo.0.4.x" opam package get installed in same cairo sub directory...
    to solve this, the best is to name opam package the same as ocamlfind package, that is to say :
    cairo1.ocaml-1.2.0 -> cairo.1.2.0 with cairo ocamlfind package (ocamlfind package not changed, only opam name);
    cairo.0.4.4 -> cairo2.0.4.4 with cairo2 ocamlfind package (ocamlfind package not changed, only opam name)
  • lablgtk2 :
    due to ocamlfind default install directory being in lib and not in lib/ocaml, (and lablGL -> lablgl renaming), it generates a problem with lablgl support in lablgtk2. solved with this commit

cairo.0.4.3 -> cairo2.0.4.3
cairo.0.4.4 -> cairo2.0.4.4
samoht added a commit that referenced this pull request Aug 21, 2013
cairo package renaming, lablgl support for lablgtk2
@samoht samoht merged commit d35ee88 into ocaml:master Aug 21, 2013
@samoht
Copy link
Member

samoht commented Aug 21, 2013

Can you please confirm on https://github.com/OCamlPro/opam-repository/issues/955 that your fine to license these patches to CC0 ?

@william3
Copy link
Contributor Author

I am not in the list, which is normal, as it is my first commit...

@samoht
Copy link
Member

samoht commented Aug 21, 2013

We are in the process of migrating the repository to CC0, so I'm trying to keep track of new contributors as well (it will be easier later when the LICENSE file will clearly located at the root of the repository). But until then, I still need to ask you to confirm that you are happy with CC0 somewhere (and the existing thread seems a good place to do so, I'll add your name on the list at the same time).

@samoht
Copy link
Member

samoht commented Aug 21, 2013

Thanks!

samoht added a commit to samoht/opam-repository that referenced this pull request Aug 22, 2013
samoht added a commit that referenced this pull request Aug 22, 2013
Propagate cairo1 -> cairo , cairo -> cairo2 changes introduced by #997
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants