-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce every files in the files/ subdirectory to be listed in extra-files #5013
Comments
the reverse should as well be checked -- since this guarantee is atm not here, conex needs to jump through some hoops (instead of "just using the hash of the opam file as the single required checksum). Is there anything that ensures directory traversal is not possible (i.e. are |
I’m not sure what you mean by that. I’ve just tried and the reverse is enforced:
As far as i can see from testing, yes. Also opam/src/state/opamFileTools.ml Line 610 in 4b103bd
|
@kit-ty-kate thanks, indeed I meant your "some-non-existent-file" case. |
to cite @AltGr
|
Currently that isn’t enforced. You can add any files (patches, …) to a package in a repository without checksums.
This should be enforced.
The text was updated successfully, but these errors were encountered: