No more populate opam file with extra-files #5564
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbou
added
the
PR: QUEUED
rjbou
force-pushed
the
undeclared-extra-files
branch
from
1f093cf
to
c668919
Compare
|
fix #5013 |
rjbou
force-pushed
the
undeclared-extra-files
branch
from
c668919
to
63b9546
Compare
This was referenced Sep 1, 2023
AltGr
approved these changes
Sep 7, 2023
|
looks good to me, but I'd as well be happy if you point me to the rebased PR once #5561 is merged :) |
… more tied to --check-upstream option
… automatically 'extra-files:' automatically from 'files/' directory
rjbou
force-pushed
the
undeclared-extra-files
branch
from
aaa554c
to
a3bdcfc
Compare
…opulate automatically 'extra-files:' automatically from 'files/' directory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behaviour is at lint stage, if an extra-files is found in
filesdirectory, but not in the opam file, it is added in the opam file automatically.This behaviour is removed, all extra-files need to be declared in opam file.
/cc @hannesm @reynir