Better shell initialisation. #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous behaviour was wrong: update .bash_profile if it exists, .bashrc otherwise. This now respects loading order of bash for login shells to be sure we update the file that will be loaded. Still, bash loads distinct files, exclusively, in login and non-login mode: either one of the profiles, or .bashrc. Unless you include one from the other, which many do, but you can't rely on that. We may end up having to load variables from _both_ files to handle both cases, loading them twice being harmless ; but I hope we don't need to. In non-interactive mode, bash doesn't load any specific files (except if BASH_ENV is defined, but defining it would be the same problem) so we're out of luck anyway.
--zsh, etc. were incomplete (no --bash !) and heavy-weight. Using --shell=x with an enum is better, and while incompatible, shouldn't cause trouble, you don't use it everyday.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #1447 (waiting for reviews and tests before closing)