Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better shell initialisation. #1965

Merged
merged 2 commits into from
Jan 28, 2015
Merged

Better shell initialisation. #1965

merged 2 commits into from
Jan 28, 2015

Commits on Jan 28, 2015

  1. Initialise env for login shells in bash 

    Previous behaviour was wrong: update .bash_profile if it exists, .bashrc otherwise.
This now respects loading order of bash for login shells to be sure we update
the file that will be loaded.

Still, bash loads distinct files, exclusively, in login and non-login mode: either
one of the profiles, or .bashrc. Unless you include one from the other, which many
do, but you can't rely on that. We may end up having to load variables from _both_
files to handle both cases, loading them twice being harmless ; but I hope we don't
need to.

In non-interactive mode, bash doesn't load any specific files (except if BASH_ENV
is defined, but defining it would be the same problem) so we're out of luck anyway.
    @AltGr
    AltGr committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    64c6e37 View commit details
    Browse the repository at this point in the history

  2. Better shell selection options 

    --zsh, etc. were incomplete (no --bash !) and heavy-weight. Using
--shell=x with an enum is better, and while incompatible, shouldn't
cause trouble, you don't use it everyday.
    @AltGr
    AltGr committed Jan 28, 2015
    Configuration menu
    Copy the full SHA
    e9826e9 View commit details
    Browse the repository at this point in the history